Skip to content

Revert "feat(multitenancy): grant Debezium replication privileges" - #100

Merged
oleksandrd-flamingo merged 1 commit into
mainfrom
revert-98-feature/cdc-user-provisioning
Aug 11, 2026
Merged

Revert "feat(multitenancy): grant Debezium replication privileges"#100
oleksandrd-flamingo merged 1 commit into
mainfrom
revert-98-feature/cdc-user-provisioning

Conversation

@oleksandrd-flamingo

@oleksandrd-flamingo oleksandrd-flamingo commented Aug 11, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown

Reverts #98

Grant Debezium privileges will be done in a different way.

Summary by CodeRabbit

  • Refactor
    • Removed automatic database change-data-capture privilege setup during migrations.
    • Removed the related success message and unused privilege-management functionality.
  • Tests
    • Removed integration coverage for automatic privilege creation, validation, idempotency, and identifier handling.

@oleksandrd-flamingo
oleksandrd-flamingo enabled auto-merge (squash) August 11, 2026 09:27
@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 0e3a11db-d1e0-45c2-bda9-f11b920a79a0

📥 Commits

Reviewing files that changed from the base of the PR and between ed998df and da34898.

⛔ Files ignored due to path filters (1)
  • openframe/docs/mysql-multitenancy-feature.md is excluded by !**/*.md
📒 Files selected for processing (3)
  • cmd/fleet/prepare.go
  • server/datastore/mysql/openframe.go
  • server/datastore/mysql/openframe_cdc_user_test.go
💤 Files with no reviewable changes (3)
  • cmd/fleet/prepare.go
  • server/datastore/mysql/openframe_cdc_user_test.go
  • server/datastore/mysql/openframe.go

Walkthrough

The database preparation flow no longer calls EnsureOpenframeCdcPrivileges or prints its success message. The MySQL datastore removes the unused strings import. The CDC privilege implementation and its integration tests are deleted.

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly states that the pull request reverts the Debezium replication privilege grant removed by the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch revert-98-feature/cdc-user-provisioning

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@oleksandrd-flamingo
oleksandrd-flamingo merged commit e05490c into main Aug 11, 2026
6 checks passed
@oleksandrd-flamingo
oleksandrd-flamingo deleted the revert-98-feature/cdc-user-provisioning branch August 11, 2026 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ivan-flamingo ivan-flamingo ivan-flamingo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@oleksandrd-flamingo @ivan-flamingo